Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Team name validation failing always. #26574

Merged
merged 2 commits into from
Aug 16, 2022
Merged

Conversation

gabriellsh
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@gabriellsh gabriellsh requested a review from a team as a code owner August 15, 2022 21:29
@gabriellsh gabriellsh added this to the 5.1.0 milestone Aug 15, 2022
@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #26574 (daa2ee2) into develop (5b8b53e) will increase coverage by 0.09%.
The diff coverage is 0.00%.

❗ Current head daa2ee2 differs from pull request most recent head a094d1c. Consider uploading reports for the commit a094d1c to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26574      +/-   ##
===========================================
+ Coverage    38.55%   38.64%   +0.09%     
===========================================
  Files          758      758              
  Lines        18816    18816              
  Branches      1459     1459              
===========================================
+ Hits          7254     7271      +17     
+ Misses       11344    11325      -19     
- Partials       218      220       +2     
Flag Coverage Δ
e2e 38.64% <0.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you create a test for this case? just to be sure we never gonna repeat this mistake again :x

@ggazzo ggazzo changed the title [FIX] Team name validation failing always. Regression: Team name validation failing always. Aug 16, 2022
@ggazzo
Copy link
Member

ggazzo commented Aug 16, 2022

I heard @souzaramon is covering this test case so we are good to go

@ggazzo ggazzo merged commit 3d80a11 into develop Aug 16, 2022
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Aug 16, 2022
@ggazzo ggazzo deleted the fix/createTeam branch August 16, 2022 13:09
csuadev pushed a commit that referenced this pull request Aug 26, 2022
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants